linux-kernel - Re: [PATCH v2] mei: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190619130051.GC27090@kroah.com>
Date:   Wed, 19 Jun 2019 15:00:51 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mei: no need to check return value of debugfs_create
 functions

On Wed, Jun 19, 2019 at 08:25:58AM +0000, Winkler, Tomas wrote:
> > 
> > When calling debugfs functions, there is no need to ever check the return
> > value.  The function can work or not, but the code logic should never do
> > something different based on this.
> 
> Maybe need to mention that API has changed in patch ' ff9fb72bc07705c00795ca48631f7fffe24d2c6b' in 5.0 
> and create_dir() doesn't return NULL but ERR_PTR() and proper checking is done inside the debugfs functions.
> Not sure how critical is that but, but this should go probably to stable 5.0+ as well. 

It's not critical at all, the odds of an error ever returning, or NULL,
from debugfs before is just as rare as it is today :)

> Ack otherwise. 

great, thanks for reviewing it.

greg k-h