linux-kernel - Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190619112822.60db3d69a09e0288f9168421@kernel.org>
Date:   Wed, 19 Jun 2019 11:28:22 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 10/21] tracing/probe: Split trace_event related data
 from trace_probe

On Tue, 18 Jun 2019 17:11:15 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 18 Jun 2019 12:23:22 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > > Oops, good catch!
> > > This part is related to caller (ftrace/perf) so should be more careful.
> > > Usually, kprobe enablement should not fail. If one of them has
> > > gone (like a probe on unloaded module), it can be fail but that
> > > should be ignored. I would like to add some additional check so that
> > > - If all kprobes are on the module which is unloaded, enablement
> > >   must be failed and return error.
> > > - If any kprobe is enabled, and others are on non-exist modules,
> > >   it should succeeded and return OK.
> > > - If any kprobe caused an error not because of unloaded module,
> > >   all other enablement should be canceled and return error.
> > > 
> > > Is that OK for you?
> > >   
> > 
> > Sounds good to me.
> 
> BTW,
> 
> I pulled in patches 1-9 and I'm starting to test them now.

Thanks! Should I send 10-21 patches in v2?

Thank you,




-- 
Masami Hiramatsu <mhiramat@...nel.org>