linux-kernel - Re: [PATCH 4.9 45/83] staging: vc04_services: prevent integer overflow in create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190619171343.GD10107@kroah.com>
Date:   Wed, 19 Jun 2019 19:13:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Martin Weinelt <martin@...uxlounge.net>
Cc:     linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH 4.9 45/83] staging: vc04_services: prevent integer
 overflow in create_pagelist()

On Wed, Jun 19, 2019 at 06:02:07PM +0200, Martin Weinelt wrote:
> Hi.
> 
> On 6/9/19 6:42 PM, Greg Kroah-Hartman wrote:
> > From: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > commit ca641bae6da977d638458e78cd1487b6160a2718 upstream.
> 
> This commit breaks the kernel build because the vchiq_pagelist_info
> struct is not defined in v4.9.182.
> 
> It was only added in v4.10, in commit
> 4807f2c0e684e907c501cb96049809d7a957dbc2.
> 
> 
> Best regards,
> 
> Martin Weinelt
> 
> 
> In file included from ./include/uapi/linux/posix_types.h:4:0,
>                  from ./include/uapi/linux/types.h:13,
>                  from ./include/linux/compiler.h:224,
>                  from ./include/linux/linkage.h:4,
>                  from ./include/linux/kernel.h:6,
>                  from
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:34:
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c: In
> function 'create_pagelist':
> ./include/linux/stddef.h:7:14: warning: return makes integer from
> pointer without a cast [-Wint-conversion]
>  #define NULL ((void *)0)
>               ^
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:385:10:
> note: in expansion of macro 'NULL'
>    return NULL;
>           ^~~~
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:391:12:
> error: invalid application of 'sizeof' to incomplete type 'struct
> vchiq_pagelist_info'
>      sizeof(struct vchiq_pagelist_info)) /
>             ^~~~~~
> In file included from ./include/uapi/linux/posix_types.h:4:0,
>                  from ./include/uapi/linux/types.h:13,
>                  from ./include/linux/compiler.h:224,
>                  from ./include/linux/linkage.h:4,
>                  from ./include/linux/kernel.h:6,
>                  from
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:34:
> ./include/linux/stddef.h:7:14: warning: return makes integer from
> pointer without a cast [-Wint-conversion]
>  #define NULL ((void *)0)
>               ^
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:394:10:
> note: in expansion of macro 'NULL'
>    return NULL;
>           ^~~~

Really?  How come all of the built tests still succeed?

Ah, arm systems :(

Odd that we didn't catch this already, sorry about that.  And that was
my fault in the backport, which the build tests did catch.  Odd that it
didn't catch the failure after that...

Anyway, thanks, I'll go revert this.

greg k-h