linux-kernel - Re: [PATCH] x86/cacheinfo: fix a -Wtype-limits warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Jun 2019 19:18:42 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Qian Cai <cai@....pw>, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/cacheinfo: fix a -Wtype-limits warning

On Wed, Jun 19, 2019 at 10:12:49AM -0700, Sean Christopherson wrote:
> Ha, no.  My comment was that it'd be worth explaining that the original
> 'c->x86_model >= 0' check was completely bogus, even if the intent was
> something like 'c->x86_model != 0'.

Nah, the intent was, I believe, to convert a model range into a
conditional. If ->x86_model is not set we have bigger problems.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.