linux-kernel - Re: [PATCH v2 02/22] ABI: Fix KernelVersion tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201906201103.6A6F68B9@keescook>
Date:   Thu, 20 Jun 2019 11:04:17 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...radead.org>,
        linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Rajat Jain <rajatja@...gle.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v2 02/22] ABI: Fix KernelVersion tags

On Thu, Jun 20, 2019 at 02:22:54PM -0300, Mauro Carvalho Chehab wrote:
> It is "KernelVersion:" and not "Kernel Version:".
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

> ---
>  Documentation/ABI/testing/pstore              |  2 +-
>  .../sysfs-bus-event_source-devices-format     |  2 +-
>  .../ABI/testing/sysfs-bus-i2c-devices-hm6352  |  6 ++---
>  .../testing/sysfs-bus-pci-devices-aer_stats   | 12 +++++-----
>  .../ABI/testing/sysfs-bus-pci-devices-cciss   | 22 +++++++++----------
>  .../testing/sysfs-bus-usb-devices-usbsevseg   | 10 ++++-----
>  .../ABI/testing/sysfs-driver-altera-cvp       |  2 +-
>  Documentation/ABI/testing/sysfs-driver-ppi    |  2 +-
>  Documentation/ABI/testing/sysfs-driver-st     |  2 +-
>  Documentation/ABI/testing/sysfs-driver-wacom  |  2 +-
>  10 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/pstore b/Documentation/ABI/testing/pstore
> index 8d6e48f4e8ef..d45209abdb1b 100644
> --- a/Documentation/ABI/testing/pstore
> +++ b/Documentation/ABI/testing/pstore
> @@ -1,6 +1,6 @@
>  What:		/sys/fs/pstore/... (or /dev/pstore/...)
>  Date:		March 2011
> -Kernel Version: 2.6.39
> +KernelVersion: 2.6.39
>  Contact:	tony.luck@...el.com
>  Description:	Generic interface to platform dependent persistent storage.
>  
> diff --git a/Documentation/ABI/testing/sysfs-bus-event_source-devices-format b/Documentation/ABI/testing/sysfs-bus-event_source-devices-format
> index b6f8748e0200..5bb793ec926c 100644
> --- a/Documentation/ABI/testing/sysfs-bus-event_source-devices-format
> +++ b/Documentation/ABI/testing/sysfs-bus-event_source-devices-format
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/event_source/devices/<dev>/format
>  Date:		January 2012
> -Kernel Version: 3.3
> +KernelVersion: 3.3
>  Contact:	Jiri Olsa <jolsa@...hat.com>
>  Description:
>  		Attribute group to describe the magic bits that go into
> diff --git a/Documentation/ABI/testing/sysfs-bus-i2c-devices-hm6352 b/Documentation/ABI/testing/sysfs-bus-i2c-devices-hm6352
> index 29bd447e50a0..4a251b7f11e4 100644
> --- a/Documentation/ABI/testing/sysfs-bus-i2c-devices-hm6352
> +++ b/Documentation/ABI/testing/sysfs-bus-i2c-devices-hm6352
> @@ -1,20 +1,20 @@
>  What:		/sys/bus/i2c/devices/.../heading0_input
>  Date:		April 2010
> -Kernel Version: 2.6.36?
> +KernelVersion: 2.6.36?
>  Contact:	alan.cox@...el.com
>  Description:	Reports the current heading from the compass as a floating
>  		point value in degrees.
>  
>  What:		/sys/bus/i2c/devices/.../power_state
>  Date:		April 2010
> -Kernel Version: 2.6.36?
> +KernelVersion: 2.6.36?
>  Contact:	alan.cox@...el.com
>  Description:	Sets the power state of the device. 0 sets the device into
>  		sleep mode, 1 wakes it up.
>  
>  What:		/sys/bus/i2c/devices/.../calibration
>  Date:		April 2010
> -Kernel Version: 2.6.36?
> +KernelVersion: 2.6.36?
>  Contact:	alan.cox@...el.com
>  Description:	Sets the calibration on or off (1 = on, 0 = off). See the
>  		chip data sheet.
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> index ff229d71961c..3c9a8c4a25eb 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> @@ -11,7 +11,7 @@ saw any problems).
>  
>  What:		/sys/bus/pci/devices/<dev>/aer_dev_correctable
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	List of correctable errors seen and reported by this
>  		PCI device using ERR_COR. Note that since multiple errors may
> @@ -33,7 +33,7 @@ TOTAL_ERR_COR 2
>  
>  What:		/sys/bus/pci/devices/<dev>/aer_dev_fatal
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	List of uncorrectable fatal errors seen and reported by this
>  		PCI device using ERR_FATAL. Note that since multiple errors may
> @@ -64,7 +64,7 @@ TOTAL_ERR_FATAL 0
>  
>  What:		/sys/bus/pci/devices/<dev>/aer_dev_nonfatal
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	List of uncorrectable nonfatal errors seen and reported by this
>  		PCI device using ERR_NONFATAL. Note that since multiple errors
> @@ -105,18 +105,18 @@ messages on the PCI hierarchy originating at that root port.
>  
>  What:		/sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	Total number of ERR_COR messages reported to rootport.
>  
>  What:	    /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	Total number of ERR_FATAL messages reported to rootport.
>  
>  What:	    /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
>  Date:		July 2018
> -Kernel Version: 4.19.0
> +KernelVersion: 4.19.0
>  Contact:	linux-pci@...r.kernel.org, rajatja@...gle.com
>  Description:	Total number of ERR_NONFATAL messages reported to rootport.
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss b/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> index eb449169c30b..92a94e1068c2 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> +++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-cciss
> @@ -1,68 +1,68 @@
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/model
>  Date:		March 2009
> -Kernel Version: 2.6.30
> +KernelVersion: 2.6.30
>  Contact:	iss_storagedev@...com
>  Description:	Displays the SCSI INQUIRY page 0 model for logical drive
>  		Y of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/rev
>  Date:		March 2009
> -Kernel Version: 2.6.30
> +KernelVersion: 2.6.30
>  Contact:	iss_storagedev@...com
>  Description:	Displays the SCSI INQUIRY page 0 revision for logical
>  		drive Y of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/unique_id
>  Date:		March 2009
> -Kernel Version: 2.6.30
> +KernelVersion: 2.6.30
>  Contact:	iss_storagedev@...com
>  Description:	Displays the SCSI INQUIRY page 83 serial number for logical
>  		drive Y of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/vendor
>  Date:		March 2009
> -Kernel Version: 2.6.30
> +KernelVersion: 2.6.30
>  Contact:	iss_storagedev@...com
>  Description:	Displays the SCSI INQUIRY page 0 vendor for logical drive
>  		Y of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/block:cciss!cXdY
>  Date:		March 2009
> -Kernel Version: 2.6.30
> +KernelVersion: 2.6.30
>  Contact:	iss_storagedev@...com
>  Description:	A symbolic link to /sys/block/cciss!cXdY
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/rescan
>  Date:		August 2009
> -Kernel Version:	2.6.31
> +KernelVersion:	2.6.31
>  Contact:	iss_storagedev@...com
>  Description:	Kicks of a rescan of the controller to discover logical
>  		drive topology changes.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/lunid
>  Date:		August 2009
> -Kernel Version: 2.6.31
> +KernelVersion: 2.6.31
>  Contact:	iss_storagedev@...com
>  Description:	Displays the 8-byte LUN ID used to address logical
>  		drive Y of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/raid_level
>  Date:		August 2009
> -Kernel Version: 2.6.31
> +KernelVersion: 2.6.31
>  Contact:	iss_storagedev@...com
>  Description:	Displays the RAID level of logical drive Y of
>  		controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/cXdY/usage_count
>  Date:		August 2009
> -Kernel Version: 2.6.31
> +KernelVersion: 2.6.31
>  Contact:	iss_storagedev@...com
>  Description:	Displays the usage count (number of opens) of logical drive Y
>  		of controller X.
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/resettable
>  Date:		February 2011
> -Kernel Version:	2.6.38
> +KernelVersion:	2.6.38
>  Contact:	iss_storagedev@...com
>  Description:	Value of 1 indicates the controller can honor the reset_devices
>  		kernel parameter.  Value of 0 indicates reset_devices cannot be
> @@ -73,7 +73,7 @@ Description:	Value of 1 indicates the controller can honor the reset_devices
>  
>  What:		/sys/bus/pci/devices/<dev>/ccissX/transport_mode
>  Date:		July 2011
> -Kernel Version:	3.0
> +KernelVersion:	3.0
>  Contact:	iss_storagedev@...com
>  Description:	Value of "simple" indicates that the controller has been placed
>  		in "simple mode". Value of "performant" indicates that the
> diff --git a/Documentation/ABI/testing/sysfs-bus-usb-devices-usbsevseg b/Documentation/ABI/testing/sysfs-bus-usb-devices-usbsevseg
> index f6199b314196..9ade80f81f96 100644
> --- a/Documentation/ABI/testing/sysfs-bus-usb-devices-usbsevseg
> +++ b/Documentation/ABI/testing/sysfs-bus-usb-devices-usbsevseg
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/usb/.../powered
>  Date:		August 2008
> -Kernel Version:	2.6.26
> +KernelVersion:	2.6.26
>  Contact:	Harrison Metzger <harrisonmetz@...il.com>
>  Description:	Controls whether the device's display will powered.
>  		A value of 0 is off and a non-zero value is on.
> @@ -8,7 +8,7 @@ Description:	Controls whether the device's display will powered.
>  What:		/sys/bus/usb/.../mode_msb
>  What:		/sys/bus/usb/.../mode_lsb
>  Date:		August 2008
> -Kernel Version:	2.6.26
> +KernelVersion:	2.6.26
>  Contact:	Harrison Metzger <harrisonmetz@...il.com>
>  Description:	Controls the devices display mode.
>  		For a 6 character display the values are
> @@ -18,7 +18,7 @@ Description:	Controls the devices display mode.
>  
>  What:		/sys/bus/usb/.../textmode
>  Date:		August 2008
> -Kernel Version:	2.6.26
> +KernelVersion:	2.6.26
>  Contact:	Harrison Metzger <harrisonmetz@...il.com>
>  Description:	Controls the way the device interprets its text buffer.
>  		raw:	each character controls its segment manually
> @@ -27,13 +27,13 @@ Description:	Controls the way the device interprets its text buffer.
>  
>  What:		/sys/bus/usb/.../text
>  Date:		August 2008
> -Kernel Version:	2.6.26
> +KernelVersion:	2.6.26
>  Contact:	Harrison Metzger <harrisonmetz@...il.com>
>  Description:	The text (or data) for the device to display
>  
>  What:		/sys/bus/usb/.../decimals
>  Date:		August 2008
> -Kernel Version:	2.6.26
> +KernelVersion:	2.6.26
>  Contact:	Harrison Metzger <harrisonmetz@...il.com>
>  Description:	Controls the decimal places on the device.
>  		To set the nth decimal place, give this field
> diff --git a/Documentation/ABI/testing/sysfs-driver-altera-cvp b/Documentation/ABI/testing/sysfs-driver-altera-cvp
> index 8cde64a71edb..fbd8078fd7ad 100644
> --- a/Documentation/ABI/testing/sysfs-driver-altera-cvp
> +++ b/Documentation/ABI/testing/sysfs-driver-altera-cvp
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/pci/drivers/altera-cvp/chkcfg
>  Date:		May 2017
> -Kernel Version:	4.13
> +KernelVersion:	4.13
>  Contact:	Anatolij Gustschin <agust@...x.de>
>  Description:
>  		Contains either 1 or 0 and controls if configuration
> diff --git a/Documentation/ABI/testing/sysfs-driver-ppi b/Documentation/ABI/testing/sysfs-driver-ppi
> index 9921ef285899..1a56fc507689 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ppi
> +++ b/Documentation/ABI/testing/sysfs-driver-ppi
> @@ -1,6 +1,6 @@
>  What:		/sys/class/tpm/tpmX/ppi/
>  Date:		August 2012
> -Kernel Version:	3.6
> +KernelVersion:	3.6
>  Contact:	xiaoyan.zhang@...el.com
>  Description:
>  		This folder includes the attributes related with PPI (Physical
> diff --git a/Documentation/ABI/testing/sysfs-driver-st b/Documentation/ABI/testing/sysfs-driver-st
> index ba5d77008a85..88cab66fd77f 100644
> --- a/Documentation/ABI/testing/sysfs-driver-st
> +++ b/Documentation/ABI/testing/sysfs-driver-st
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/scsi/drivers/st/debug_flag
>  Date:		October 2015
> -Kernel Version:	?.?
> +KernelVersion:	?.?
>  Contact:	shane.seymour@....com
>  Description:
>  		This file allows you to turn debug output from the st driver
> diff --git a/Documentation/ABI/testing/sysfs-driver-wacom b/Documentation/ABI/testing/sysfs-driver-wacom
> index 2aa5503ee200..afc48fc163b5 100644
> --- a/Documentation/ABI/testing/sysfs-driver-wacom
> +++ b/Documentation/ABI/testing/sysfs-driver-wacom
> @@ -1,6 +1,6 @@
>  What:		/sys/bus/hid/devices/<bus>:<vid>:<pid>.<n>/speed
>  Date:		April 2010
> -Kernel Version:	2.6.35
> +KernelVersion:	2.6.35
>  Contact:	linux-bluetooth@...r.kernel.org
>  Description:
>  		The /sys/bus/hid/devices/<bus>:<vid>:<pid>.<n>/speed file
> -- 
> 2.21.0
> 

-- 
Kees Cook