linux-kernel - Re: [PATCH] scsi: bnx2fc: Check if sense buffer has been allocated during completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1v9x0q8uq.fsf@oracle.com>
Date:   Thu, 20 Jun 2019 16:50:53 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Young Xiao <92siuyang@...il.com>
Cc:     QLogic-Storage-Upstream@...gic.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bnx2fc: Check if sense buffer has been allocated during completion


Hi Young,

> sc_cmd->sense_buffer is not guaranteed to be allocated so we need to
> sc_cmd->check if the pointer is NULL before trying to copy anything
> into it.

bnx2fc does not appear to use a driver-specific sense buffer.

-- 
Martin K. Petersen	Oracle Linux Engineering