lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jun 2019 16:37:55 -0500 From: Bjorn Helgaas <helgaas@...nel.org> To: Puranjay Mohan <puranjay12@...il.com> Cc: Shuah Khan <skhan@...uxfoundation.org>, Bjorn Helgaas <bjorn@...gaas.com>, netdev <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-kernel-mentees@...ts.linuxfoundation.org, linux-pci@...r.kernel.org Subject: Re: [PATCH v2 2/3] net: fddi: skfp: Include generic PCI definitions On Thu, Jun 20, 2019 at 11:37:53PM +0530, Puranjay Mohan wrote: > Include the uapi/linux/pci_regs.h header file which contains the generic > PCI defines. > > Signed-off-by: Puranjay Mohan <puranjay12@...il.com> > --- > drivers/net/fddi/skfp/drvfbi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/fddi/skfp/drvfbi.c b/drivers/net/fddi/skfp/drvfbi.c > index b324c1acf195..e8245cb281f8 100644 > --- a/drivers/net/fddi/skfp/drvfbi.c > +++ b/drivers/net/fddi/skfp/drvfbi.c > @@ -20,7 +20,7 @@ > #include "h/supern_2.h" > #include "h/skfbiinc.h" > #include <linux/bitrev.h> > - > +#include <linux/pci_regs.h> You removed the blank line between the list of include files and the SCCS ID (now there's an anachronism) below. That blank line is part of typical Linux style and you should keep it. > #ifndef lint > static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ; > #endif > -- > 2.21.0 >
Powered by blists - more mailing lists