lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Jun 2019 11:19:16 +0300 From: Felipe Balbi <felipe.balbi@...ux.intel.com> To: Chunfeng Yun <chunfeng.yun@...iatek.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Matthias Brugger <matthias.bgg@...il.com>, Chunfeng Yun <chunfeng.yun@...iatek.com>, linux-usb@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH] usb: dwc3: remove unused @lock member of dwc3_ep struct Hi, Chunfeng Yun <chunfeng.yun@...iatek.com> writes: > The member @lock of dwc2_ep struct is only initialized, > and not used elsewhere, so remove it. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com> > --- > drivers/usb/dwc3/core.h | 2 -- > drivers/usb/dwc3/gadget.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index f19cbeb01087..72d28cb14bdf 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -649,7 +649,6 @@ struct dwc3_event_buffer { > * @cancelled_list: list of cancelled requests for this endpoint > * @pending_list: list of pending requests for this endpoint > * @started_list: list of started requests on this endpoint > - * @lock: spinlock for endpoint request queue traversal > * @regs: pointer to first endpoint register > * @trb_pool: array of transaction buffers > * @trb_pool_dma: dma address of @trb_pool > @@ -677,7 +676,6 @@ struct dwc3_ep { > struct list_head pending_list; > struct list_head started_list; > > - spinlock_t lock; > void __iomem *regs; > > struct dwc3_trb *trb_pool; > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index d67655384eb2..7f75da30caba 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2251,8 +2251,6 @@ static int dwc3_gadget_init_endpoint(struct dwc3 *dwc, u8 epnum) > dep->endpoint.comp_desc = NULL; > } > > - spin_lock_init(&dep->lock); heh, thanks. This is left-over from when I playing with further paralelizing the driver. Turned out that there are not enough gains to justify that work. I'll apply this patch. -- balbi
Powered by blists - more mailing lists