linux-kernel - Re: [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5da5b498-cbc7-26dd-bd68-7f2376eb6b30@nvidia.com>
Date:   Thu, 20 Jun 2019 11:01:05 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Sameer Pujar <spujar@...dia.com>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>, <mkumard@...dia.com>,
        <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes


On 20/06/2019 10:39, Thierry Reding wrote:
> On Wed, Jun 19, 2019 at 05:21:21PM +0530, Sameer Pujar wrote:
>> Add DT nodes for following devices on Tegra186 and Tegra194
>>  * ACONNECT
>>  * ADMA
>>  * AGIC
>>
>> Signed-off-by: Sameer Pujar <spujar@...dia.com>
>> ---
>>  changes in current revision
>>    * updated ranges property for aconnect
>>    * renamed agic node
>>
>>  arch/arm64/boot/dts/nvidia/tegra186.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  2 files changed, 134 insertions(+)
> 
> Applied to for-5.3/arm64/dt, thanks.
> 
> I ended up deciding to put the aconnect node among the nodes with unit-
> addresses, in the numerical order that it would fit in if the top-level
> aconnect node didn't exist. I think that looks much more consistent in
> the end, even though it's slightly bending the rules that we have.

Thanks. Good point, I had not thought that bit through. Works for me,
especially as the aconnect bus has a ranges property and so is
associated with an address range.

Cheers
Jon

-- 
nvpublic