linux-kernel - Re: [PATCH] usb: remove redundant 'default n' from Kconfig-s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190620120821.GA19295@kroah.com>
Date:   Thu, 20 Jun 2019 14:08:21 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Felipe Balbi <balbi@...nel.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: remove redundant 'default n' from Kconfig-s

On Tue, Jun 18, 2019 at 10:29:58AM +0300, Felipe Balbi wrote:
> Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com> writes:
> 
> > 'default n' is the default value for any bool or tristate Kconfig
> > setting so there is no need to write it explicitly.
> >
> > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> > is not set' for visible symbols") the Kconfig behavior is the same
> > regardless of 'default n' being present or not:
> >
> >     ...
> >     One side effect of (and the main motivation for) this change is making
> >     the following two definitions behave exactly the same:
> >     
> >         config FOO
> >                 bool
> >     
> >         config FOO
> >                 bool
> >                 default n
> >     
> >     With this change, neither of these will generate a
> >     '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> >     That might make it clearer to people that a bare 'default n' is
> >     redundant.
> >     ...
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> 
> Fine by me. Greg if you want to take this directly (since it touches
> things all over the place):
> 
> Acked-by: Felipe Balbi <felipe.balbi@...ux.intel.com>
> 
> If you prefer that I put this in my pull request to you, just let me know.

I think I already took this :)