linux-kernel - Re: [PATCH] media: mt9m111: fix fw-node refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190620123509.7pssbcqjqcnh3kmc@valkosipuli.retiisi.org.uk>
Date:   Thu, 20 Jun 2019 15:35:09 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Enrico Scholz <enrico.scholz@...ma-chemnitz.de>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: mt9m111: fix fw-node refactoring

On Thu, Jun 20, 2019 at 01:17:17PM +0300, Sakari Ailus wrote:
> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
> index bd3a51c3b081..9761a6105407 100644
> --- a/drivers/media/i2c/mt9m111.c
> +++ b/drivers/media/i2c/mt9m111.c
> @@ -1263,9 +1263,11 @@ static int mt9m111_probe(struct i2c_client *client,
>  	if (!mt9m111)
>  		return -ENOMEM;
>  
> -	ret = mt9m111_probe_fw(client, mt9m111);
> -	if (ret)
> -		return ret;
> +	if (dev_fwnode(client->dev)) {

&client->dev

> +		ret = mt9m111_probe_fw(client, mt9m111);
> +		if (ret)
> +			return ret;
> +	}
>  
>  	mt9m111->clk = v4l2_clk_get(&client->dev, "mclk");
>  	if (IS_ERR(mt9m111->clk))

-- 
Sakari Ailus