linux-kernel - Re: [PATCH 1/2] auxdisplay/cfag12864bfb.c: Convert to use vm_map_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jun 2019 15:10:39 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH 1/2] auxdisplay/cfag12864bfb.c: Convert to use vm_map_pages_zero()

On Sun, May 26, 2019 at 6:05 PM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> While using mmap, the incorrect values of length and vm_pgoff are
> ignored and this driver goes ahead with mapping cfag12864b_buffer
> to user vma.
>
> Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> "fix" these drivers to behave according to the normal vm_pgoff
> offsetting simply by removing the _zero suffix on the function name and
> if that causes regressions, it gives us an easy way to revert.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> ---
> v2: Fixed minor typo.

Almost forgot about these two -- picking both v2s for a PR later. Not
sure what happened with the mm/ related one I sent, is it in Andrew's
tree?

Cheers,
Miguel