linux-kernel - Re: [PATCH v2 2/8] staging: erofs: add compacted compression indexes support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d04f83f7-9f01-e736-cc1b-8ee438e47d3c@huawei.com>
Date:   Fri, 21 Jun 2019 16:08:30 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Chao Yu <yuchao0@...wei.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <devel@...verdev.osuosl.org>, LKML <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>, <linux-erofs@...ts.ozlabs.org>,
        Chao Yu <chao@...nel.org>, Fang Wei <fangwei1@...wei.com>,
        Miao Xie <miaoxie@...wei.com>, Du Wei <weidu.du@...wei.com>
Subject: Re: [PATCH v2 2/8] staging: erofs: add compacted compression indexes
 support



On 2019/6/21 15:53, Chao Yu wrote:
> On 2019/6/21 0:07, Gao Xiang wrote:
>> This patch aims at compacted compression indexes:
>>  1) cleanup z_erofs_map_blocks_iter and move into zmap.c;
>>  2) add compacted 4/2B decoding support.
>>
>> On kirin980 platform, sequential read is increased about
>> 6% (725MiB/s -> 770MiB/s) on enwik9 dataset if compacted 2B
>> feature is enabled.
>>
>> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>
> 
>> +static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m,
>> +					     unsigned long lcn)
>> +{
>> +	struct inode *const inode = m->inode;
>> +	struct erofs_vnode *const vi = EROFS_V(inode);
>> +	const erofs_off_t ibase = iloc(EROFS_I_SB(inode), vi->nid);
>> +	const erofs_off_t pos = Z_EROFS_VLE_EXTENT_ALIGN(ibase +
>> +							 vi->inode_isize +
>> +							 vi->xattr_isize) +
>> +		16 + lcn * sizeof(struct z_erofs_vle_decompressed_index);
> 
> use macro instead of raw number?

OK, I will wrap it up in patch v3 too.

Thanks,
Gao Xiang

> 
> Thanks,
>