linux-kernel - Re: [PATCH V5 2/3] PCI: dwc: Cleanup DBI read and write APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e23ef76b-e74a-ee29-05c2-5c09f206ee36@nvidia.com>
Date:   Fri, 21 Jun 2019 15:17:01 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     Kishon Vijay Abraham I <kishon@...com>, <jingoohan1@...il.com>,
        <gustavo.pimentel@...opsys.com>, <lorenzo.pieralisi@....com>,
        <bhelgaas@...gle.com>, <Jisheng.Zhang@...aptics.com>,
        <thierry.reding@...il.com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kthota@...dia.com>, <mmaddireddy@...dia.com>, <sagar.tv@...il.com>
Subject: Re: [PATCH V5 2/3] PCI: dwc: Cleanup DBI read and write APIs

On 6/21/2019 2:57 PM, Kishon Vijay Abraham I wrote:
> Hi Vidya,
> 
> On 21/06/19 2:51 PM, Vidya Sagar wrote:
>> Cleanup DBI read and write APIs by removing "__" (underscore) from their
>> names as there are no no-underscore versions and the underscore versions
>> are already doing what no-underscore versions typically do.
>>
>> Signed-off-by: Vidya Sagar <vidyas@...dia.com>
>> ---
>> Changes from v4:
>> * This is a new patch in this series
>>
>>   drivers/pci/controller/dwc/pcie-designware.c | 16 ++++-----
>>   drivers/pci/controller/dwc/pcie-designware.h | 36 ++++++++++----------
>>   2 files changed, 26 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
>> index 9d7c51c32b3b..5d22028d854e 100644
>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>> @@ -52,8 +52,8 @@ int dw_pcie_write(void __iomem *addr, int size, u32 val)
>>   	return PCIBIOS_SUCCESSFUL;
>>   }
>>   
>> -u32 __dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
>> -		       size_t size)
>> +u32 dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
>> +		     size_t size)
> 
> The "base" here was added when we used the same API for both dbi_base and
> dbi_base2. Now that we have separate APIs, we should be able to remove that.
> 
> Thanks
> Kishon
> 
Got it. Let me address it.