linux-kernel - Re: [PATCH] mmc: remove another TMIO MMC variant usdhi6rol0.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190621105025.GA2987@kunai>
Date:   Fri, 21 Jun 2019 12:50:25 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Rabin Vincent <rabin.vincent@...s.com>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] mmc: remove another TMIO MMC variant usdhi6rol0.c

Hi,

On Fri, Jun 21, 2019 at 03:16:11PM +0900, Masahiro Yamada wrote:
> (Added Lars Persson, Guennadi Liakhovetski)
> 
> On Fri, Jun 21, 2019 at 3:06 PM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
> 
> This needs Ack from Renesas.
> But, I do not know if TMIO folks are sure about this driver, though.
> (If they had been sure about it, they should not have duplicated the driver
> in the first place.)

... and from the original mail:

> Delete this driver now. Please re-implement it based on tmio_mmc_core.c
> if needed.

I was never happy with this driver existing, yet I never knew which HW
platform needed this, so I didn't touch it. But I'd like to see it go in
favor of merging with the TMIO code base.

> 
> Perhaps, some code snippets in this driver might be useful for cleaning
> tmio_mmc. It will stay in git history forever, and you can dig for it
> whenever you need it.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

I double checked there is no user in the current tree. I also searched
the web and did not find any out-of-tree user or even a reference of it.

So, for now:

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

But this seriously needs an Ack from Shimoda-san or Morimoto-san. And
maybe Guennadi has remarks, too?

Thanks,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)