[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1628618a-7cf6-506e-9d87-c0966a99fbea@samsung.com>
Date: Fri, 21 Jun 2019 12:58:26 +0200
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To: Arnd Bergmann <arnd@...db.de>
Cc: YueHaibing <yuehaibing@...wei.com>,
Ira Weiny <ira.weiny@...el.com>,
Andrew Morton <akpm@...ux-foundation.org>,
dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: pvr2fb: fix link error for
pvr2fb_pci_exit
Hi,
On 6/17/19 3:16 PM, Arnd Bergmann wrote:
> When the driver is built-in for PCI, we reference the exit function
> after discarding it:
>
> `pvr2fb_pci_exit' referenced in section `.ref.data' of drivers/video/fbdev/pvr2fb.o: defined in discarded section `.exit.text' of drivers/video/fbdev/pvr2fb.o
>
> Just remove the __exit annotation as the easiest workaround.
Don't we also need to fix pvr2fb_dc_exit() for CONFIG_SH_DREAMCAST=y case?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/video/fbdev/pvr2fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index 299ea7db9220..cf9cfdc5e685 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -990,7 +990,7 @@ static int __init pvr2fb_pci_init(void)
> return pci_register_driver(&pvr2fb_pci_driver);
> }
>
> -static void __exit pvr2fb_pci_exit(void)
> +static void pvr2fb_pci_exit(void)
> {
> pci_unregister_driver(&pvr2fb_pci_driver);
> }
Powered by blists - more mailing lists