linux-kernel - Re: [PATCH v4 3/5] mm, thp: introduce FOLL_SPLIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190621124402.z4l67ck4vr5g7xe3@box>
Date:   Fri, 21 Jun 2019 15:44:02 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Song Liu <songliubraving@...com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org, oleg@...hat.com,
        rostedt@...dmis.org, mhiramat@...nel.org,
        matthew.wilcox@...cle.com, kirill.shutemov@...ux.intel.com,
        kernel-team@...com
Subject: Re: [PATCH v4 3/5] mm, thp: introduce FOLL_SPLIT_PMD

On Thu, Jun 13, 2019 at 10:57:45AM -0700, Song Liu wrote:
> @@ -419,6 +419,11 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
>  			put_page(page);
>  			if (pmd_none(*pmd))
>  				return no_page_table(vma, flags);
> +		} else {  /* flags & FOLL_SPLIT_PMD */
> +			spin_unlock(ptl);
> +			ret = 0;
> +			split_huge_pmd(vma, pmd, address);
> +			pte_alloc(mm, pmd);

pte_alloc() can fail and the failure should be propogated to the caller.

-- 
 Kirill A. Shutemov