linux-kernel - Re:Re: [PATCH] kexec: fix warnig of crash_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jun 2019 21:38:44 +0800 (CST)
From:   "Tiezhu Yang" <kernelpatch@....com>
To:     "Borislav Petkov" <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org, vgoyal@...hat.com
Subject: Re:Re: [PATCH] kexec: fix warnig of crash_zero_bytes in crash.c

At 2019-06-21 00:39:00, "Borislav Petkov" <bp@...en8.de> wrote:
>On Sat, Jun 15, 2019 at 07:18:20AM +0800, Tiezhu Yang wrote:
>> This patch fixes the following sparse warning:
>
>Avoid having "This patch" or "This commit" in the commit message. It is
>tautologically useless.
>
>Also, do
>
>$ git grep 'This patch' Documentation/process
>
>for more details.
>
>> arch/x86/kernel/crash.c:59:15:
>> warning: symbol 'crash_zero_bytes' was not declared. Should it be static?
>> 
>> In addition, crash_zero_bytes is used when CONFIG_KEXEC_FILE is
>> set, so make it only available under CONFIG_KEXEC_FILE. Otherwise,
>> if CONFIG_KEXEC_FILE is not set, the following warning will appear:
>> 
>> arch/x86/kernel/crash.c:59:22:
>> warning: ‘crash_zero_bytes’ defined but not used [-Wunused-variable]
>
>That happens only when you make it static, so please state that in the
>commit message.

Thanks for your suggestion, I will send a v2 patch.

Thanks,

>
>Thx.
>
>-- 
>Regards/Gruss,
>    Boris.
>
>Good mailing practices for 400: avoid top-posting and trim the reply.