linux-kernel - Re: PCI/AER sysfs files violate the rules of how sysfs works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190621141550.GG82584@google.com>
Date:   Fri, 21 Jun 2019 09:15:50 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Rajat Jain <rajatja@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: PCI/AER sysfs files violate the rules of how sysfs works

On Fri, Jun 21, 2019 at 09:29:11AM +0200, Greg KH wrote:
> Hi,
> 
> When working on some documentation scripts to show the
> Documentation/ABI/ files in an automated way, I ran across this "gem" of
> a sysfs file: Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> 
> In it you describe how the files
> /sys/bus/pci/devices/<dev>/aer_dev_correctable and
> /sys/bus/pci/devices/<dev>/aer_dev_fatal and
> /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
> all display a bunch of text on multiple lines.
> 
> This violates the "one value per sysfs file" rule, and should never have
> been merged as-is :(
> 
> Please fix it up to be a lot of individual files if your really need all
> of those different values.

Sorry about that.  Do you think we're safe in changing the sysfs ABI
by removing the original files and replacing them with new, better
ones?  This is pretty new and hopefully not widely used yet.

Bjorn