linux-kernel - Re: [PATCH] video: fbdev: pvr2fb: fix compile-testing as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3=5iMx4UEi6pX6AGGsZWHzyiMQRNnUHuA4peZbGQRQZw@mail.gmail.com>
Date:   Fri, 21 Jun 2019 16:22:07 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Mike Marshall <hubcap@...ibond.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Ira Weiny <ira.weiny@...el.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: pvr2fb: fix compile-testing as module

On Fri, Jun 21, 2019 at 1:15 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@...sung.com> wrote:
>
>
> On 6/17/19 2:47 PM, Arnd Bergmann wrote:
> > Building an allmodconfig kernel now produces a harmless warning:
> >
> > drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function]
> >
> > Shut this up the same way as we do for other unused functions
> > in the same file, using the __maybe_unused attribute.
> >
> > Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Thanks but I've fixed it already by adding #ifndef MODULE (since other
> functions in the same file using __maybe_unused depend on either PCI or
> SH_DREAMCAST I've preferred not to use this attribute):
>
> https://marc.info/?l=linux-fbdev&m=156050904010778&w=2

Ok, dropping my patch from the local queue, your version is obviously
correct as well.

      Arnd