linux-kernel - Re: [PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D327ABC9-2B43-473C-AD1C-080EEB067E62@fb.com>
Date:   Fri, 21 Jun 2019 16:56:49 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Joel Stanley <joel@....id.au>
CC:     Arnd Bergmann <arnd@...db.de>, Andrew Jeffery <andrew@...id.au>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: aspeed: lpc-ctrl: Fix probe error handling



On 6/20/19, 2:17 AM, "joel.stan@...il.com on behalf of Joel Stanley" <joel.stan@...il.com on behalf of joel@....id.au> wrote:

    gcc warns that a mising "flash" phandle node leads to undefined
    behavior later:
    
    drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe':
    drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    Only set the flash base and size if we find a phandle in the device
    tree.
    
Thanks for fixing this.
Reviewed-by: Vijay Khemka <vijaykhemka@...com>

    Reported-by: Arnd Bergmann <arnd@...db.de>
    Signed-off-by: Joel Stanley <joel@....id.au>
    ---
     drivers/soc/aspeed/aspeed-lpc-ctrl.c | 5 +++--
     1 file changed, 3 insertions(+), 2 deletions(-)
    
    diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
    index aca13779764a..eee26c2d8b52 100644
    --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c
    +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c
    @@ -223,10 +223,11 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
     			dev_err(dev, "Couldn't address to resource for flash\n");
     			return rc;
     		}
    +
    +		lpc_ctrl->pnor_size = resource_size(&resm);
    +		lpc_ctrl->pnor_base = resm.start;
     	}
     
    -	lpc_ctrl->pnor_size = resource_size(&resm);
    -	lpc_ctrl->pnor_base = resm.start;
     
     	dev_set_drvdata(&pdev->dev, lpc_ctrl);
     
    -- 
    2.20.1