linux-kernel - Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4607058.UzJteFJyig@g550jk>
Date:   Fri, 21 Jun 2019 21:25:17 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     Brian Masney <masneyb@...tation.org>
Cc:     linux-arm-msm@...r.kernel.org,
        ~martijnbraam/pmos-upstream@...ts.sr.ht,
        Andy Gross <agross@...nel.org>,
        David Brown <david.brown@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

On Freitag, 21. Juni 2019 02:01:22 CEST you wrote:
> I think that it makes sense to put this snippet in qcom-msm8974.dtsi
> with a status of disabled, and then enable it in
> qcom-msm8974-fairphone-fp2.dts like so:
> 
> imem@...05000 {
> 	status = "ok";
> };

Do you want me to put the whole node in the the dtsi file? Even though these 
values are the same, there are also custom vendor-specified values for specific 
phones.

This opens another question, which values we should put into the dts files. For 
example in the fairphone 2 bootloader source there's also the unused
#define ALARM_BOOT        0x77665503

and behind a #if VERIFIED_BOOT :
#define DM_VERITY_LOGGING    0x77665508
#define DM_VERITY_ENFORCING  0x77665509
#define DM_VERITY_KEYSCLEAR  0x7766550A

and 0x77665501 ("mode-normal") isn't used in the bootloader at all.

On the Linux kernel side, it has bootloader (0x77665500), recovery 
(0x77665502), rtc (0x77665503), oem-* (0x6f656d00 | somevalue), edl (some 
other addresses), and the else statements writes the 0x77665501 value in my 
patch.

> What's the pmOS utility that utilizes this? I'll test it on the Nexus 5.

"reboot-mode" at https://gitlab.com/postmarketOS/pmaports/merge_requests/442

> Thanks,
> 
> Brian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)