linux-kernel - Re: [PATCH 1/4] block: add zone open, close and finish support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190622060444.GA6975@minwooim-desktop>
Date:   Sat, 22 Jun 2019 15:04:44 +0900
From:   Minwoo Im <minwoo.im.dev@...il.com>
To:     Matias Bjørling <mb@...htnvm.io>
Cc:     axboe@...com, hch@....de, damien.lemoal@....com,
        chaitanya.kulkarni@....com, dmitry.fomichev@....com,
        ajay.joshi@....com, aravind.ramesh@....com,
        martin.petersen@...cle.com, James.Bottomley@...senPartnership.com,
        agk@...hat.com, snitzer@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        dm-devel@...hat.com,
        Matias Bjørling <matias.bjorling@....com>
Subject: Re: [PATCH 1/4] block: add zone open, close and finish support

On 19-06-21 15:07:08, Matias Bjørling wrote:
> @@ -226,6 +228,9 @@ int blkdev_reset_zones(struct block_device *bdev,
>  	if (!blk_queue_is_zoned(q))
>  		return -EOPNOTSUPP;
>  
> +	if (!op_is_zone_mgmt_op(op))
> +		return -EOPNOTSUPP;
> +

nitpick: -EINVAL looks better to return as Damien pointed out.

Otherwise it looks good to me:

Reviewed-by: Minwoo Im <minwoo.im.dev@...il.com>