linux-kernel - Re: [PATCH stable-4.4 v3] coredump: fix race condition between mmget_not_zero()/get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190622162710.GA15805@dhcp22.suse.cz>
Date:   Sat, 22 Jun 2019 18:27:10 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Ajay Kaher <akaher@...are.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        "Stable tree ," <stable@...r.kernel.org>,
        "Jason Gunthorpe ," <jgg@...lanox.com>,
        "linux-mm@...ck.org, LKML ," <linux-kernel@...r.kernel.org>,
        "Andrea Arcangeli ," <aarcange@...hat.com>,
        "Jann Horn ," <jannh@...gle.com>,
        "Oleg Nesterov ," <oleg@...hat.com>,
        "Peter Xu ," <peterx@...hat.com>,
        "Mike Rapoport ," <rppt@...ux.ibm.com>,
        "Andrew Morton ," <akpm@...ux-foundation.org>,
        "Linus Torvalds ," <torvalds@...ux-foundation.org>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH stable-4.4 v3] coredump: fix race condition between
 mmget_not_zero()/get_task_mm() and core dumping

On Sat 22-06-19 06:30:37, Ajay Kaher wrote:
> 
> > On Mon, Jun 17, 2019 at 08:58:24AM +0200, Michal Hocko wrote:
> > > From: Andrea Arcangeli <aarcange@...hat.com>
> > > 
> > > Upstream 04f5866e41fb70690e28397487d8bd8eea7d712a commit.
> > > 
> > > Signed-off-by: Michal Hocko <mhocko@...e.com>
> > > ---
> > >  drivers/android/binder.c          |  6 ++++++
> > >  drivers/infiniband/hw/mlx4/main.c |  3 +++
> > >  fs/proc/task_mmu.c                | 18 ++++++++++++++++++
> > >  fs/userfaultfd.c                  | 10 ++++++++--
> > >  include/linux/mm.h                | 21 +++++++++++++++++++++
> > >  mm/mmap.c                         |  7 ++++++-
> > >  6 files changed, 62 insertions(+), 3 deletions(-)
> >
> > I've queued this up now, as it looks like everyone agrees with it.  What
> > about a 4.9.y backport?
> 
> Greg, it's here please review.
> https://lore.kernel.org/stable/1561208539-29682-1-git-send-email-akaher@vmware.com/T/#m53eaf6e687cb27e46395173aa74a85c2ccb5c190
> 
> Michal, patched for binder code Thanks, would you like to suggest 
> if mmget_still_valid check require anywhere for khugepaged code.

khugepaged patch has gone its own way. See 59ea6d06cfa9 ("coredump: fix
race condition between collapse_huge_page() and core dumping")
-- 
Michal Hocko
SUSE Labs