linux-kernel - Re: [PATCH net-next] hinic: implement the statistical interface of ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Jun 2019 16:42:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        luoshaokai@...wei.com, cloud.wangxiaoyun@...wei.com,
        chiqijun@...wei.com, wulike1@...wei.com
Subject: Re: [PATCH net-next] hinic: implement the statistical interface of
 ethtool

From: Xue Chaojing <xuechaojing@...wei.com>
Date: Thu, 20 Jun 2019 05:58:08 +0000

> +			p = (char *)(&txq_stats) +
> +				hinic_tx_queue_stats[j].offset;

Parenthesis around &txq_stats is unnecessary.

> +			p = (char *)(&rxq_stats) +
> +				hinic_rx_queue_stats[j].offset;

Similarly for &rxq_stats.

> +		p = (char *)(net_stats) + hinic_netdev_stats[j].offset;

Similarly for net_stats.

> +		p = (char *)(&vport_stats) + hinic_function_stats[j].offset;

And &vport_stats.

> +		p = (char *)(port_stats) + hinic_port_stats[j].offset;

And port_stats.