linux-kernel - Re: [PATCH V2 2/3] clocksource: imx-sysctr: Add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jun 2019 14:17:31 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Anson.Huang@....com
cc:     daniel.lezcano@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, l.stach@...gutronix.de,
        abel.vesa@....com, ccaione@...libre.com, angus@...ea.ca,
        andrew.smirnov@...il.com, agx@...xcpu.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Linux-imx@....com
Subject: Re: [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option

On Sun, 23 Jun 2019, Anson.Huang@....com wrote:

Again the short summary could be more informative. Instead of 'Add foo' you
could say:

    .....: Make timer work with platform driver model

That sums up the real meat of the patch. 'Add some option' is pretty
uninformative.

> On some i.MX8M platforms, clock driver uses platform driver
> model and it is NOT ready during timer initialization phase,
> the clock operations will fail and system counter driver will
> fail too. As all the i.MX8M platforms' system counter clock
> are from OSC which is always enabled, so it is no need to enable
> clock for system counter driver, the ONLY thing is to pass
> clock frequence to driver.
> 
> This patch adds an option of skipping of_clk operation for
> system counter driver, an optional property "clock-frequency"
> is introduced to pass the frequency value to system counter
> driver and indicate driver to skip of_clk operations.

The comments to the changelog of patch 1 apply here as well :)

Hint: 'This patch'

Thanks,

	tglx