lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Jun 2019 23:14:55 +0900 From: Katsuhiro Suzuki <katsuhiro@...suster.net> To: Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org Cc: Andrew Lunn <andrew@...n.ch>, Heiko Stuebner <heiko@...ech.de>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: stmmac regression on ASUS TinkerBoard Hello stmmac maintainers, I found this commit and that has some regressions: 74371272f97f net: stmmac: Convert to phylink and remove phylib logic My environment is: - ASUS TinkerBoard - SoC is RK3288 - Using STMMAC driver drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c - Using this device-tree arch/arm/boot/dts/rk3288.dtsi ('gmac: ethernet@...90000' node) Current linux-next on my environment, 'ifconfig eth0 up' does not work correctly with following message... ----- root@...aro-alip:~# ifconfig eth0 up [ 105.028916] rk_gmac-dwmac ff290000.ethernet eth0: stmmac_open: Cannot attach to PHY (error: -19) SIOCSIFFLAGS: No such device ----- I checked drivers/net/ethernet/stmicro/stmmac/stmmac_main.c and found stmmac_init_phy() is going to fail if ethernet device node does not have following property: - phy-handle - phy - phy-device This commit broke the device-trees such as TinkerBoard. The mdio subnode creating a mdio bus is changed to required or still optional? Best Regards, Katsuhiro Suzuki
Powered by blists - more mailing lists