linux-kernel - Re: [PATCH] parisc: asm: psw.h: missing header guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8264763.oMOxLtkXCx@daneel.sf-tec.de>
Date:   Sun, 23 Jun 2019 18:01:41 +0200
From:   Rolf Eike Beer <eike-kernel@...tec.de>
To:     Denis Efremov <efremov@...ux.com>
Cc:     "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: asm: psw.h: missing header guard

Denis Efremov wrote:
> The psw.h header file contains #ifndef directive of the guard,
> but the complimentary #define directive is missing. The patch
> adds the appropriate #define to fix the header guard.
> 
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> ---
>  arch/parisc/include/asm/psw.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/parisc/include/asm/psw.h b/arch/parisc/include/asm/psw.h
> index 76c301146c31..7a175e866ed0 100644
> --- a/arch/parisc/include/asm/psw.h
> +++ b/arch/parisc/include/asm/psw.h
> @@ -1,5 +1,6 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  #ifndef _PARISC_PSW_H
> +#define _PARISC_PSW_H
> 
> 
>  #define	PSW_I	0x00000001

You could have removed one of the 2 empty lines then.

Eike
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)