linux-kernel - Re: [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jun 2019 22:03:42 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Christian Lamparter <chunkeey@...il.com>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and
 uPD720202 w/o ROM

On 21-06-19, 21:59, Christian Lamparter wrote:
> On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote:
> > +	/*
> > +	 * The Firmware's Data Format is describe in
> > +	 * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124
> > +	 */
> > +
> > +	/* "Each row is 8 bytes". => firmware size must be a multiple of 8. */
> > +	if (length % 8 != 0)
> > +		dev_warn(&dev->dev, "firmware size is not a multiple of 8.");
> 
> It doesn't look like this holds true for the newer K2026090.mem which
> arguably fixes a lot of bugs over K2013080.mem. I think we should remove
> this check and message.

The documentation still says so, that is why I changed error return and
this to warning. Yeah lets remove to not confuse folks :)

-- 
~Vinod