lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 23 Jun 2019 14:34:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gomonovych@...il.com
Cc:     george.cherian@...ium.com, herbert@...dor.apana.org.au,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: cavium remove casting dma_alloc

From: Vasyl Gomonovych <gomonovych@...il.com>
Date: Sun, 23 Jun 2019 22:48:49 +0200

> @@ -233,7 +233,7 @@ static int alloc_command_queues(struct cpt_vf *cptvf,
>  
>  			c_size = (rem_q_size > qcsize_bytes) ? qcsize_bytes :
>  					rem_q_size;
> -			curr->head = (u8 *)dma_alloc_coherent(&pdev->dev,
> +			curr->head = dma_alloc_coherent(&pdev->dev,
>  							      c_size + CPT_NEXT_CHUNK_PTR_SIZE,
>  							      &curr->dma_addr,
>  							      GFP_KERNEL);

Please fix up the indentation of the 2nd, 3rd, and 4th line of the call
if you do this.  Each of those lines should start precisely at the
first column after the openning parenthesis of the first line.

Thank you.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ