linux-kernel - Re: [PATCH v5 5/5] x86/umwait: Document umwait control sysfs interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1906240043310.32342@nanos.tec.linutronix.de>
Date:   Mon, 24 Jun 2019 00:46:24 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Fenghua Yu <fenghua.yu@...el.com>
cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        H Peter Anvin <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ashok Raj <ashok.raj@...el.com>,
        Tony Luck <tony.luck@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v5 5/5] x86/umwait: Document umwait control sysfs
 interfaces

On Mon, 24 Jun 2019, Thomas Gleixner wrote:
> On Wed, 19 Jun 2019, Fenghua Yu wrote:
> > +Description:	Umwait control
> > +
> > +		enable_c02: Read/write interface to control umwait C0.2 state
> > +			Read returns C0.2 state status:
> > +				0: C0.2 is disabled
> > +				1: C0.2 is enabled
> > +
> > +			Write 'Yy1' or [oO][nN] for on to enable C0.2 state.
> 
>   Write 'Yy1' ? You meant [Yy1] I assume.
> 
> > +			Write 'Nn0' or [oO][fF] for off to disable C0.2 state.
>   
> What about avoiding all that unreadable confusion?
> 
>                         Write 'y' or '1'  or 'on' to enable C0.2 state.
>                         Write 'n' or '0'  or 'of' to disable C0.2 state.
> 
>                         The interface is case insensitive.

Don't try to fixup all that in a hurry.

I've already done most of it while trying to ready if for merging. If you
see the tip bot mails coming in, make sure to double check my modifications
and yell if I screwed up on the way.

Thanks,

	tglx