linux-kernel - Re: [PATCH V2 00/15] cleanup cppcheck signed shifting errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190624140212.p6xvcg5lhtgeeogc@shell.armlinux.org.uk>
Date:   Mon, 24 Jun 2019 15:02:12 +0100
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Phong Tran <tranmanphong@...il.com>
Cc:     acme@...nel.org, alexander.shishkin@...ux.intel.com,
        alexander.sverdlin@...il.com, allison@...utok.net, andrew@...n.ch,
        ast@...nel.org, bgolaszewski@...libre.com, bpf@...r.kernel.org,
        daniel@...earbox.net, daniel@...que.org, dmg@...ingmachine.org,
        festevam@...il.com, gerg@...inux.org, gregkh@...uxfoundation.org,
        gregory.clement@...tlin.com, haojian.zhuang@...il.com,
        hsweeten@...ionengravers.com, illusionist.neo@...il.com,
        info@...ux.net, jason@...edaemon.net, jolsa@...hat.com,
        kafai@...com, kernel@...gutronix.de, kgene@...nel.org,
        krzk@...nel.org, kstewart@...uxfoundation.org,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, liviu.dudau@....com,
        lkundrak@...sk, lorenzo.pieralisi@....com, mark.rutland@....com,
        mingo@...hat.com, namhyung@...nel.org, netdev@...r.kernel.org,
        nsekhar@...com, peterz@...radead.org, robert.jarzmik@...e.fr,
        s.hauer@...gutronix.de, sebastian.hesselbarth@...il.com,
        shawnguo@...nel.org, songliubraving@...com, sudeep.holla@....com,
        swinslow@...il.com, tglx@...utronix.de, tony@...mide.com,
        will@...nel.org, yhs@...com
Subject: Re: [PATCH V2 00/15] cleanup cppcheck signed shifting errors

On Mon, Jun 24, 2019 at 08:50:50PM +0700, Phong Tran wrote:
> There are errors with cppcheck 
> 
> "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
> 
> This is just a mirror changing. 

"mirror" ?

Apart from that and the extra unnecessary parens (which ought to be
cleaned up) this looks fine to me.

When there's too many parens next to each other, it makes reading
the expression more difficult - and that is definitely bad, so please
avoid unecessary parens where possible.

Thanks.

> 
> V2: Using BIT() macro instead of (1UL << nr) 
> 
> Phong Tran (15):
>   arm: perf: cleanup cppcheck shifting error
>   ARM: davinci: cleanup cppcheck shifting errors
>   ARM: ep93xx: cleanup cppcheck shifting errors
>   ARM: exynos: cleanup cppcheck shifting error
>   ARM: footbridge: cleanup cppcheck shifting error
>   ARM: imx: cleanup cppcheck shifting errors
>   ARM: ks8695: cleanup cppcheck shifting error
>   ARM: mmp: cleanup cppcheck shifting errors
>   ARM: omap2: cleanup cppcheck shifting error
>   ARM: orion5x: cleanup cppcheck shifting errors
>   ARM: pxa: cleanup cppcheck shifting errors
>   ARM: vexpress: cleanup cppcheck shifting error
>   ARM: mm: cleanup cppcheck shifting errors
>   ARM: bpf: cleanup cppcheck shifting error
>   ARM: vfp: cleanup cppcheck shifting errors
> 
>  arch/arm/kernel/perf_event_v7.c    |   6 +-
>  arch/arm/mach-davinci/ddr2.h       |   6 +-
>  arch/arm/mach-ep93xx/soc.h         | 132 ++++++++++++++++++-------------------
>  arch/arm/mach-exynos/suspend.c     |   2 +-
>  arch/arm/mach-footbridge/dc21285.c |   2 +-
>  arch/arm/mach-imx/iomux-mx3.h      |  64 +++++++++---------
>  arch/arm/mach-ks8695/regs-pci.h    |   4 +-
>  arch/arm/mach-mmp/pm-mmp2.h        |  40 +++++------
>  arch/arm/mach-mmp/pm-pxa910.h      |  76 ++++++++++-----------
>  arch/arm/mach-omap2/powerdomain.c  |   2 +-
>  arch/arm/mach-orion5x/pci.c        |   8 +--
>  arch/arm/mach-pxa/irq.c            |   4 +-
>  arch/arm/mach-vexpress/spc.c       |  12 ++--
>  arch/arm/mm/fault.h                |   6 +-
>  arch/arm/net/bpf_jit_32.c          |   2 +-
>  arch/arm/vfp/vfpinstr.h            |   8 +--
>  16 files changed, 187 insertions(+), 187 deletions(-)
> 
> -- 
> 2.11.0
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up