linux-kernel - Re: [PATCH] platform/chrome: cros_ec_lpc: fix stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 09:18:51 -0600
From:   Nick Crews <ncrews@...omium.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        kbuild-all@...org, Ezequiel Garcia <ezequiel@...labora.com>,
        Benson Leung <bleung@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings

I applied this in the new version as well.

On Fri, Jun 21, 2019 at 6:55 PM kbuild test robot <lkp@...el.com> wrote:
>
> From: kbuild test robot <lkp@...el.com>
>
> drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
>
> Generated by: scripts/coccinelle/api/stream_open.cocci
>
> Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
> Signed-off-by: kbuild test robot <lkp@...el.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
> head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
> commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime
>
> Please take the patch only if it's a positive warning. Thanks!
>
>  event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -267,7 +267,7 @@ static int event_open(struct inode *inod
>
>         /* Increase refcount on device so dev_data is not freed */
>         get_device(&dev_data->dev);
> -       nonseekable_open(inode, filp);
> +       stream_open(inode, filp);
>         filp->private_data = dev_data;
>
>         return 0;