linux-kernel - Re: [PATCH net-next] net: macb: use NAPI_POLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa8dbdde-7fd2-24f4-b9db-6112152b25c4@microchip.com>
Date:   Mon, 24 Jun 2019 15:58:02 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <antoine.tenart@...tlin.com>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Ludovic.Desroches@...rochip.com>, <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT

On 21/06/2019 at 17:28, Antoine Tenart wrote:
> Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of
> redefining our own value (which turns out to be 64 as well).
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   drivers/net/ethernet/cadence/macb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 163deba244ab..1cd1f2c36d6f 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -3490,7 +3490,7 @@ static int macb_init(struct platform_device *pdev)
>   
>   		queue = &bp->queues[q];
>   		queue->bp = bp;
> -		netif_napi_add(dev, &queue->napi, macb_poll, 64);
> +		netif_napi_add(dev, &queue->napi, macb_poll, NAPI_POLL_WEIGHT);
>   		if (hw_q) {
>   			queue->ISR  = GEM_ISR(hw_q - 1);
>   			queue->IER  = GEM_IER(hw_q - 1);
> 


-- 
Nicolas Ferre