linux-kernel - Re: [PATCH] pinctrl: Add device link between pin controller and GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZMP3hfAdcJjs1EUMnB5naN7NHsrKFHi9xJ4k5XWCnFFw@mail.gmail.com>
Date:   Tue, 25 Jun 2019 00:36:38 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: Add device link between pin controller and GPIO

On Fri, Jun 21, 2019 at 5:24 PM Thierry Reding <thierry.reding@...il.com> wrote:

> From: Thierry Reding <treding@...dia.com>
>
> When a GPIO controller registers a pin range with a pin controller,
> establish a device link between them in order to keep track of the
> dependency, which will help keep the right suspend/resume ordering.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>

This make sense.

> +               link = device_link_add(range->gc->parent, pctldev->dev,
> +                                      DL_FLAG_AUTOREMOVE_CONSUMER);

What about parentless GPIO chips now again?
The parent field is optional, sad to say (yes I wish I could just
fix it all).

> +                       device_link_remove(range->gc->parent, pctldev->dev);

And here again.

Yours,
Linus Walleij