linux-kernel - Re: [PATCH -mm] mm, swap: Fix THP swap out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ef3jbfs8.fsf@yhuang-dev.intel.com>
Date:   Mon, 24 Jun 2019 15:31:35 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, Michal Hocko <mhocko@...nel.org>,
        "Johannes Weiner" <hannes@...xchg.org>,
        Hugh Dickins <hughd@...gle.com>,
        Minchan Kim <minchan@...nel.org>,
        Rik van Riel <riel@...hat.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>
Subject: Re: [PATCH -mm] mm, swap: Fix THP swap out

Ming Lei <ming.lei@...hat.com> writes:

> On Mon, Jun 24, 2019 at 12:44:41PM +0800, Huang, Ying wrote:
>> Ming Lei <ming.lei@...hat.com> writes:
>> 
>> > Hi Huang Ying,
>> >
>> > On Mon, Jun 24, 2019 at 10:23:36AM +0800, Huang, Ying wrote:
>> >> From: Huang Ying <ying.huang@...el.com>
>> >> 
>> >> 0-Day test system reported some OOM regressions for several
>> >> THP (Transparent Huge Page) swap test cases.  These regressions are
>> >> bisected to 6861428921b5 ("block: always define BIO_MAX_PAGES as
>> >> 256").  In the commit, BIO_MAX_PAGES is set to 256 even when THP swap
>> >> is enabled.  So the bio_alloc(gfp_flags, 512) in get_swap_bio() may
>> >> fail when swapping out THP.  That causes the OOM.
>> >> 
>> >> As in the patch description of 6861428921b5 ("block: always define
>> >> BIO_MAX_PAGES as 256"), THP swap should use multi-page bvec to write
>> >> THP to swap space.  So the issue is fixed via doing that in
>> >> get_swap_bio().
>> >> 
>> >> BTW: I remember I have checked the THP swap code when
>> >> 6861428921b5 ("block: always define BIO_MAX_PAGES as 256") was merged,
>> >> and thought the THP swap code needn't to be changed.  But apparently,
>> >> I was wrong.  I should have done this at that time.
>> >> 
>> >> Fixes: 6861428921b5 ("block: always define BIO_MAX_PAGES as 256")
>> >> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>> >> Cc: Ming Lei <ming.lei@...hat.com>
>> >> Cc: Michal Hocko <mhocko@...nel.org>
>> >> Cc: Johannes Weiner <hannes@...xchg.org>
>> >> Cc: Hugh Dickins <hughd@...gle.com>
>> >> Cc: Minchan Kim <minchan@...nel.org>
>> >> Cc: Rik van Riel <riel@...hat.com>
>> >> Cc: Daniel Jordan <daniel.m.jordan@...cle.com>
>> >> ---
>> >>  mm/page_io.c | 7 ++-----
>> >>  1 file changed, 2 insertions(+), 5 deletions(-)
>> >> 
>> >> diff --git a/mm/page_io.c b/mm/page_io.c
>> >> index 2e8019d0e048..4ab997f84061 100644
>> >> --- a/mm/page_io.c
>> >> +++ b/mm/page_io.c
>> >> @@ -29,10 +29,9 @@
>> >>  static struct bio *get_swap_bio(gfp_t gfp_flags,
>> >>  				struct page *page, bio_end_io_t end_io)
>> >>  {
>> >> -	int i, nr = hpage_nr_pages(page);
>> >>  	struct bio *bio;
>> >>  
>> >> -	bio = bio_alloc(gfp_flags, nr);
>> >> +	bio = bio_alloc(gfp_flags, 1);
>> >>  	if (bio) {
>> >>  		struct block_device *bdev;
>> >>  
>> >> @@ -41,9 +40,7 @@ static struct bio *get_swap_bio(gfp_t gfp_flags,
>> >>  		bio->bi_iter.bi_sector <<= PAGE_SHIFT - 9;
>> >>  		bio->bi_end_io = end_io;
>> >>  
>> >> -		for (i = 0; i < nr; i++)
>> >> -			bio_add_page(bio, page + i, PAGE_SIZE, 0);
>> >
>> > bio_add_page() supposes to work, just wondering why it doesn't recently.
>> 
>> Yes.  Just checked and bio_add_page() works too.  I should have used
>> that.  The problem isn't bio_add_page(), but bio_alloc(), because nr ==
>> 512 > 256, mempool cannot be used during swapout, so swapout will fail.
>
> Then we can pass 1 to bio_alloc(), together with single bio_add_page()
> for making the code more readable.
>

Yes.  Will send out v2 to replace __bio_add_page() with bio_add_page().

Best Regards,
Huang, Ying