linux-kernel - Re: [PATCH 1/6] cpufreq: Use existing stub functions instead of IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ce0d1ca-154d-fca3-f739-573ecbd2b0db@linaro.org>
Date:   Mon, 24 Jun 2019 10:53:28 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     viresh.kumar@...aro.org
Cc:     edubezval@...il.com, linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "open list:CPU FREQUENCY SCALING FRAMEWORK" 
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/6] cpufreq: Use existing stub functions instead of
 IS_ENABLED macro


Hi Viresh,

On 21/06/2019 15:22, Daniel Lezcano wrote:
> The functions stub already exist for the condition the IS_ENABLED
> is trying to avoid.
> 
> Remove the IS_ENABLED macros as they are pointless.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>

what about this one?

> ---
>  drivers/cpufreq/cpufreq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 85ff958e01f1..7c72f7d3509c 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1378,8 +1378,7 @@ static int cpufreq_online(unsigned int cpu)
>  	if (cpufreq_driver->ready)
>  		cpufreq_driver->ready(policy);
>  
> -	if (IS_ENABLED(CONFIG_CPU_THERMAL) &&
> -	    cpufreq_driver->flags & CPUFREQ_IS_COOLING_DEV)
> +	if (cpufreq_driver->flags & CPUFREQ_IS_COOLING_DEV)
>  		policy->cdev = of_cpufreq_cooling_register(policy);
>  
>  	pr_debug("initialization complete\n");
> @@ -1469,8 +1468,7 @@ static int cpufreq_offline(unsigned int cpu)
>  		goto unlock;
>  	}
>  
> -	if (IS_ENABLED(CONFIG_CPU_THERMAL) &&
> -	    cpufreq_driver->flags & CPUFREQ_IS_COOLING_DEV) {
> +	if (cpufreq_driver->flags & CPUFREQ_IS_COOLING_DEV) {
>  		cpufreq_cooling_unregister(policy->cdev);
>  		policy->cdev = NULL;
>  	}
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog