linux-kernel - Re: [PATCH][next] clocksource: davinci-timer: fix memory leak of clockevent on error return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c80982ee-c1e1-2f12-ad75-90f1fe6c9bae@canonical.com>
Date:   Mon, 24 Jun 2019 10:07:59 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] clocksource: davinci-timer: fix memory leak of
 clockevent on error return

On 24/06/2019 10:03, Dan Carpenter wrote:
> On Mon, Jun 24, 2019 at 10:28:10AM +0200, Bartosz Golaszewski wrote:
>> pon., 17 cze 2019 o 13:31 Colin King <colin.king@...onical.com> napisał(a):
>>>
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> Currently when the call to request_irq falls there is a memory leak of
>>> clockevent on the error return path. Fix this by kfree'ing clockevent.
>>>
>>> Addresses-Coverity: ("Resource leak")
>>> Fixes: fe3b8194f274 ("clocksource: davinci-timer: add support for clockevents")
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>> ---
>>>  drivers/clocksource/timer-davinci.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
>>> index a9ca02390b66..8512f12e250a 100644
>>> --- a/drivers/clocksource/timer-davinci.c
>>> +++ b/drivers/clocksource/timer-davinci.c
>>> @@ -300,6 +300,7 @@ int __init davinci_timer_register(struct clk *clk,
>>>                          "clockevent/tim12", clockevent);
>>>         if (rv) {
>>>                 pr_err("Unable to request the clockevent interrupt");
>>> +               kfree(clockevent);
>>>                 return rv;
>>>         }
>>>
>>> --
>>> 2.20.1
>>>
>>
>> Hi Colin,
>>
>> I omitted the error checking in this driver on purpose - it doesn't
>> make sense as the system won't boot without a timer.
> 
> One way to silence these static checker warnings is to use
> "GFP_KERNEL | __GFP_NOFAIL".

/me notes that down to for future reference, thanks again Dan for your
wise input.

> 
> regards,
> dan carpenter
>