linux-kernel - Re: [PATCH] mm/vmalloc: fix a compile warning in mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Jun 2019 11:41:28 +0200
From:   Uladzislau Rezki <urezki@...il.com>
To:     Weitao Hou <houweitaoo@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Roman Penyaev <rpenyaev@...e.de>, Roman Gushchin <guro@...com>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/vmalloc: fix a compile warning in mm

Hello, Hou.

It has already been fixed. Please have a look at:

https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning.patch
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uninitialized-warning-fix.patch

--
Vlad Rezki

On Mon, Jun 24, 2019 at 7:09 AM Weitao Hou <houweitaoo@...il.com> wrote:
>
> mm/vmalloc.c: In function ‘pcpu_get_vm_areas’:
> mm/vmalloc.c:976:4: warning: ‘lva’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> insert_vmap_area_augment(lva, &va->rb_node,
>
> Signed-off-by: Weitao Hou <houweitaoo@...il.com>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 4c9e150e5ad3..78c5617fdf3f 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
>         unsigned long nva_start_addr, unsigned long size,
>         enum fit_type type)
>  {
> -       struct vmap_area *lva;
> +       struct vmap_area *lva = NULL;
>
>         if (type == FL_FIT_TYPE) {
>                 /*
> --
> 2.18.0
>


-- 
Uladzislau Rezki