linux-kernel - Re: drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <258fa411-43a7-14dc-95c2-6a3b336b3871@web.de>
Date:   Mon, 24 Jun 2019 13:00:39 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        kernel-janitors@...r.kernel.org
Cc:     Enrico Weigelt <lkml@...ux.net>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Keerthy <j-keerthy@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: drivers: Adjust scope for CONFIG_HAS_IOMEM before
 devm_platform_ioremap_resource()

> In its current form it makes the code even less readable.

This can be your development opinion.


> The #ifdef should actually be one line lower

I suggested that the conditional compilation can contain also a blank line
together with a comment block.


> and touch the comment instead of the EXPORT_SYMBOL() related to a different function.

I find that this macro call was kept unchanged.

Regards,
Markus