[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190624110737.GU3419@hirez.programming.kicks-ass.net>
Date: Mon, 24 Jun 2019 13:07:37 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Jessica Yu <jeyu@...nel.org>, linux-kernel@...r.kernel.org,
jpoimboe@...hat.com, jikos@...nel.org, mbenes@...e.cz,
pmladek@...e.com, ast@...nel.org, daniel@...earbox.net,
akpm@...ux-foundation.org
Cc: Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>,
Yonghong Song <yhs@...com>, netdev@...r.kernel.org,
bpf@...r.kernel.org
Subject: Re: [PATCH 3/3] module: Properly propagate MODULE_STATE_COMING
failure
On Mon, Jun 24, 2019 at 11:18:46AM +0200, Peter Zijlstra wrote:
> Now that notifiers got unbroken; use the proper interface to handle
> notifier errors and propagate them.
>
> There were already MODULE_STATE_COMING notifiers that failed; notably:
>
> - jump_label_module_notifier()
> - tracepoint_module_notify()
> - bpf_event_notify()
>
> By propagating this error, we fix those users.
>
> Cc: Jessica Yu <jeyu@...nel.org>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Daniel Borkmann <daniel@...earbox.net>
> Cc: Martin KaFai Lau <kafai@...com>
> Cc: Song Liu <songliubraving@...com>
> Cc: Yonghong Song <yhs@...com>
> Cc: linux-kernel@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: bpf@...r.kernel.org
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> ---
> kernel/module.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3643,9 +3643,10 @@ static int prepare_coming_module(struct
> if (err)
> return err;
>
> - blocking_notifier_call_chain(&module_notify_list,
> - MODULE_STATE_COMING, mod);
> - return 0;
> + err = blocking_notifier_call_chain_error(&module_notify_list,
> + MODULE_STATE_COMING, MODULE_STATE_GOING, mod);
> +
> + return notifier_to_errno(err);
> }
Argh, I messed up that klp thing again :/
Powered by blists - more mailing lists