lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Jun 2019 20:10:05 +0800 From: liaoweixiong <liaoweixiong@...winnertech.com> To: Schrempf Frieder <frieder.schrempf@...tron.de>, Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Marek Vasut <marek.vasut@...il.com>, Vignesh Raghavendra <vigneshr@...com>, Boris Brezillon <bbrezillon@...nel.org>, Frieder Schrempf <frieder.schrempf@...eet.de>, Peter Pan <peterpandong@...ron.com>, Jeff Kletsky <git-commits@...ycomm.com> Cc: "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] mtd: spinand: read return badly if the last page has bitflips OK, thanks for your reviewing. I will resend right now. On 2019/6/24 PM3:37, Schrempf Frieder wrote: > On 20.06.19 03:00, liaoweixiong wrote: >> In case of the last page containing bitflips (ret > 0), >> spinand_mtd_read() will return that number of bitflips for the last >> page. But to me it looks like it should instead return max_bitflips like >> it does when the last page read returns with 0. >> >> Signed-off-by: liaoweixiong <liaoweixiong@...winnertech.com> > > Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de> > > This should probably be resent with the following tags: > > Cc: stable@...r.kernel.org > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI > NANDs") > >> --- >> drivers/mtd/nand/spi/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c >> index 556bfdb..6b9388d 100644 >> --- a/drivers/mtd/nand/spi/core.c >> +++ b/drivers/mtd/nand/spi/core.c >> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, >> if (ret == -EBADMSG) { >> ecc_failed = true; >> mtd->ecc_stats.failed++; >> - ret = 0; >> } else { >> mtd->ecc_stats.corrected += ret; >> max_bitflips = max_t(unsigned int, max_bitflips, ret); >> } >> >> + ret = 0; >> ops->retlen += iter.req.datalen; >> ops->oobretlen += iter.req.ooblen; >> } -- liaoweixiong
Powered by blists - more mailing lists