linux-kernel - Re: [patch] crypto: ccp - Free ccp if initialization fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15049ef5-c705-037b-b63e-09aa6f098bdf@amd.com>
Date:   Mon, 24 Jun 2019 13:04:30 +0000
From:   "Lendacky, Thomas" <Thomas.Lendacky@....com>
To:     David Rientjes <rientjes@...gle.com>,
        "Hook, Gary" <Gary.Hook@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>
CC:     "Singh, Brijesh" <brijesh.singh@....com>,
        Cfir Cohen <cfir@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [patch] crypto: ccp - Free ccp if initialization fails

On 6/23/19 2:18 PM, David Rientjes wrote:
> If ccp_dev_init() fails, kfree() the allocated ccp since it will otherwise
> be leaked.

Not needed. It's allocated with devm_kzalloc(), so it won't be leaked.

Thanks,
Tom

> 
> Fixes: 720419f01832 ("crypto: ccp - Introduce the AMD Secure Processor
> device")
> 
> Reported-by: Cfir Cohen <cfir@...gle.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  drivers/crypto/ccp/ccp-dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccp/ccp-dev.c b/drivers/crypto/ccp/ccp-dev.c
> --- a/drivers/crypto/ccp/ccp-dev.c
> +++ b/drivers/crypto/ccp/ccp-dev.c
> @@ -609,6 +609,7 @@ int ccp_dev_init(struct sp_device *sp)
>  
>  e_err:
>  	sp->ccp_data = NULL;
> +	kfree(ccp);
>  
>  	dev_notice(dev, "ccp initialization failed\n");
>  
>