linux-kernel - Re: [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190625184848.1b2e5dfe@kitsune.suse.cz>
Date:   Tue, 25 Jun 2019 18:48:48 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-crypto@...r.kernel.org, chetjain@...ibm.com,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: algapi - guard against uninitialized spawn list
 in crypto_remove_spawns

On Tue, 25 Jun 2019 09:40:54 -0700
Eric Biggers <ebiggers@...nel.org> wrote:

Hello,

> Hi Michal,
> 

> The stack trace shows that crypto_remove_spawns() is being called from
> crypto_unregister_instance().  Therefore, the instance should already be
> registered and have initialized cra_users.  Now, I don't claim to understand the
> spawn lists stuff that well, so I could have missed something; but if there *is*
> a bug, I'd like to see a proper explanation.

Unfortunately, I don't have an explanation either.
> 
> Did you check whether this is actually reproducible on mainline, and not just
> the SUSE v4.12 based kernel?

Mainline crashes on boot:/

Need to find a recent working kernel.

Thanks

Michal