linux-kernel - Re: [PATCH v3 0/2] Support accelerometers for veyron

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5326bfb8-611f-765b-1c9c-c95032102c71@collabora.com>
Date:   Tue, 25 Jun 2019 19:09:50 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Gwendal Grignou <gwendal@...omium.org>, jic23@...nel.org,
        bleung@...omium.org, groeck@...omium.org,
        fabien.lahoudere@...labora.com, dianders@...omium.org
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Support accelerometers for veyron_minnie

Hi,

On 25/6/19 0:53, Gwendal Grignou wrote:
> veyron_minnie - ASUS Chromebook Flip C100PA - embedded controller
> controls two accelerometers, one in the lid, one in the base.
> However, the EC firmware does not follow the new interface that
> cros_ec_accel driver use.
> Extend the legacy driver used on glimmer - Lenovo ThinkPad 11e
> Chromebook - to veyron_minnie.
> veyron_minnie being ARM based, issue command over the I2C bus to the EC
> instead of relying on the shared registers over LPC.
> 
> Gwendal Grignou (2):
>   iio: cros_ec: Add sign vector in core for backward compatibility
>   iio: cros_ec: Extend legacy support to ARM device
> 
> Changes in v3:
> - Fix commit message, add reviewed-by for first patch.
> 
> Changes in v2:
> - Readd empty line to reduce amount of change in patch.
> - Remove Keywords used by ChromeOS commit queue.
> 
>  drivers/iio/accel/Kconfig                     |   4 +-
>  drivers/iio/accel/cros_ec_accel_legacy.c      | 350 ++++--------------
>  .../cros_ec_sensors/cros_ec_sensors_core.c    |   4 +
>  .../linux/iio/common/cros_ec_sensors_core.h   |   1 +
>  4 files changed, 84 insertions(+), 275 deletions(-)
> 

Just a side note that I think that this patch depends on [1] to have the legacy
sensors working on veyron minnie.

For the full series:

Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>


[1] https://lkml.org/lkml/2019/6/18/268