linux-kernel - Re: [PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190625172106.26xxbeiwpn4avykh@willie-the-truck>
Date:   Tue, 25 Jun 2019 18:21:07 +0100
From:   Will Deacon <will@...nel.org>
To:     Phong Tran <tranmanphong@...il.com>
Cc:     acme@...nel.org, alexander.shishkin@...ux.intel.com,
        alexander.sverdlin@...il.com, allison@...utok.net, andrew@...n.ch,
        ast@...nel.org, bgolaszewski@...libre.com, bpf@...r.kernel.org,
        daniel@...earbox.net, daniel@...que.org, dmg@...ingmachine.org,
        festevam@...il.com, gerg@...inux.org, gregkh@...uxfoundation.org,
        gregory.clement@...tlin.com, haojian.zhuang@...il.com,
        hsweeten@...ionengravers.com, illusionist.neo@...il.com,
        info@...ux.net, jason@...edaemon.net, jolsa@...hat.com,
        kafai@...com, kernel@...gutronix.de, kgene@...nel.org,
        krzk@...nel.org, kstewart@...uxfoundation.org,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux@...linux.org.uk,
        liviu.dudau@....com, lkundrak@...sk, lorenzo.pieralisi@....com,
        mark.rutland@....com, mingo@...hat.com, namhyung@...nel.org,
        netdev@...r.kernel.org, nsekhar@...com, peterz@...radead.org,
        robert.jarzmik@...e.fr, s.hauer@...gutronix.de,
        sebastian.hesselbarth@...il.com, shawnguo@...nel.org,
        songliubraving@...com, sudeep.holla@....com, swinslow@...il.com,
        tglx@...utronix.de, tony@...mide.com, yhs@...com
Subject: Re: [PATCH V3 01/15] arm: perf: cleanup cppcheck shifting error

On Tue, Jun 25, 2019 at 11:03:42AM +0700, Phong Tran wrote:
> There is error from cppcheck tool
> "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
> change to use BIT() marco for improvement.

s/marco/macro/

As Peter pointed out, this "error" is also a false positive also for the
kernel.

> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>  arch/arm/kernel/perf_event_v7.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
> index a4fb0f8b8f84..2924d7910b10 100644
> --- a/arch/arm/kernel/perf_event_v7.c
> +++ b/arch/arm/kernel/perf_event_v7.c
> @@ -697,9 +697,9 @@ static struct attribute_group armv7_pmuv2_events_attr_group = {
>  /*
>   * Event filters for PMUv2
>   */
> -#define	ARMV7_EXCLUDE_PL1	(1 << 31)
> -#define	ARMV7_EXCLUDE_USER	(1 << 30)
> -#define	ARMV7_INCLUDE_HYP	(1 << 27)
> +#define	ARMV7_EXCLUDE_PL1	BIT(31)
> +#define	ARMV7_EXCLUDE_USER	BIT(30)
> +#define	ARMV7_INCLUDE_HYP	BIT(27)

Acked-by: Will Deacon <will.deacon@....com>

You can drop this into Russell's patch system[1].

Will

[1] https://www.arm.linux.org.uk/developer/patches/