linux-kernel - Re: [PATCH v2] lib/mpi: fix build with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190625181549.GK7313@gate.crashing.org>
Date:   Tue, 25 Jun 2019 13:15:49 -0500
From:   Segher Boessenkool <segher@...nel.crashing.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Joel Stanley <joel@....id.au>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib/mpi: fix build with clang

Hi Mathieu,

On Fri, Jun 21, 2019 at 09:55:54PM +0200, Mathieu Malaterre wrote:
> Remove superfluous casts on output operands to avoid warnings on the
> following macros:
> 
> * add_ssaaaa(sh, sl, ah, al, bh, bl)
> * sub_ddmmss(sh, sl, ah, al, bh, bl)
> * umul_ppmm(ph, pl, m0, m1)

The patch is fine of course, but you might want to look at not using
these asm macros at all: GCC can handle multi-word arithmetic just fine
by itself, probably better than these macros do even.


Segher