linux-kernel - Re: [PATCH V3 04/15] ARM: exynos: cleanup cppcheck shifting error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190625184951.GA10025@kozik-lap>
Date:   Tue, 25 Jun 2019 20:49:51 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Phong Tran <tranmanphong@...il.com>
Cc:     acme@...nel.org, alexander.shishkin@...ux.intel.com,
        alexander.sverdlin@...il.com, allison@...utok.net, andrew@...n.ch,
        ast@...nel.org, bgolaszewski@...libre.com, bpf@...r.kernel.org,
        daniel@...earbox.net, daniel@...que.org, dmg@...ingmachine.org,
        festevam@...il.com, gerg@...inux.org, gregkh@...uxfoundation.org,
        gregory.clement@...tlin.com, haojian.zhuang@...il.com,
        hsweeten@...ionengravers.com, illusionist.neo@...il.com,
        info@...ux.net, jason@...edaemon.net, jolsa@...hat.com,
        kafai@...com, kernel@...gutronix.de, kgene@...nel.org,
        kstewart@...uxfoundation.org, linux-arm-kernel@...ts.infradead.org,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux@...linux.org.uk, liviu.dudau@....com, lkundrak@...sk,
        lorenzo.pieralisi@....com, mark.rutland@....com, mingo@...hat.com,
        namhyung@...nel.org, netdev@...r.kernel.org, nsekhar@...com,
        peterz@...radead.org, robert.jarzmik@...e.fr,
        s.hauer@...gutronix.de, sebastian.hesselbarth@...il.com,
        shawnguo@...nel.org, songliubraving@...com, sudeep.holla@....com,
        swinslow@...il.com, tglx@...utronix.de, tony@...mide.com,
        will@...nel.org, yhs@...com
Subject: Re: [PATCH V3 04/15] ARM: exynos: cleanup cppcheck shifting error

On Tue, Jun 25, 2019 at 11:03:45AM +0700, Phong Tran wrote:
> There is error from cppcheck tool
> "Shifting signed 32-bit value by 31 bits is undefined behaviour errors"
> change to use BIT() marco for improvement.
> 
> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>  arch/arm/mach-exynos/suspend.c | 2 +-

Thanks, applied with slightly different commit message. As Peter
pointed, there is no error because of GCC.  Usually we expect a reply to
comments on LKML...  and also you could take his hints and use them to
improve the commit msg to properly describe what is the problem.

Best regards,
Krzysztof