linux-kernel - Re: [PATCH v2] drivers/block/loop: Replace deprecated function in option parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 19:24:25 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Florian Knauf <florian.knauf@...d.uni-hannover.de>
CC:     "linux-kernel@...cs.fau.de" <linux-kernel@...cs.fau.de>,
        Jens Axboe <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christian Ewert <christian.ewert@...d.uni-hannover.de>
Subject: Re: [PATCH v2] drivers/block/loop: Replace deprecated function in
 option parsing code

I believe you have tested this patch with loop testcases present in the 
:- https://github.com/osandov/blktests/tree/master/tests/loop.

With that, looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>.

On 06/25/2019 10:55 AM, Florian Knauf wrote:
> This patch removes the deprecated simple_strtol function from the option
> parsing logic in the loopback device driver. Instead kstrtoint is used to
> parse int max_loop, to ensure that input values it cannot represent are
> ignored.
>
> Signed-off-by: Florian Knauf <florian.knauf@...d.uni-hannover.de>
> Signed-off-by: Christian Ewert <christian.ewert@...d.uni-hannover.de>
> ---
> Thank you for your feedback.
>
> There's no specific reason to use kstrtol, other than the fact that we
> weren't yet aware that kstrtoint exists. (We're new at this, I'm afraid.)
>
> We've amended the patch to make use of kstrtoint, which is of course much
> more straightforward.
>
> drivers/block/loop.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 102d79575895..adfaf4ad37d1 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -2289,7 +2289,7 @@ module_exit(loop_exit);
>   #ifndef MODULE
>   static int __init max_loop_setup(char *str)
>   {
> -	max_loop = simple_strtol(str, NULL, 0);
> +	kstrtoint(str, 0, &max_loop);
>   	return 1;
>   }
>
>