linux-kernel - Re: [PATCH v6 1/2] fTPM: firmware TPM running in TEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jun 2019 13:01:05 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sasha Levin <sashal@...nel.org>, peterhuewe@....de,
        jarkko.sakkinen@...ux.intel.com, jgg@...pe.ca
Cc:     corbet@....net, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...rosoft.com, thiruan@...rosoft.com,
        bryankel@...rosoft.com, tee-dev@...ts.linaro.org,
        ilias.apalodimas@...aro.org, sumit.garg@...aro.org
Subject: Re: [PATCH v6 1/2] fTPM: firmware TPM running in TEE

Hi,

On 6/25/19 12:52 PM, Sasha Levin wrote:
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 88a3c06fc153..facee3bb5607 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -164,6 +164,11 @@ config TCG_VTPM_PROXY
>  	  /dev/vtpmX and a server-side file descriptor on which the vTPM
>  	  can receive commands.
>  
> +config TCG_FTPM_TEE
> +	tristate "TEE based fTPM Interface"
> +	depends on TEE && OPTEE
> +	---help---
> +	  This driver proxies for fTPM running in TEE

acronym overload.  For the help text, I would at least s/fTPM/firmware TPM/.
Also, end that sentence with a '.'.

>  
>  source "drivers/char/tpm/st33zp24/Kconfig"
>  endif # TCG_TPM


-- 
~Randy